Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582163 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxx --- Comment #4 from Paul Howarth <paul@xxxxxxxxxxxx> 2010-05-12 03:04:30 EDT --- The guidelines say to choose either the "%{buildroot}" form or the "$RPM_BUILD_ROOT" form (either are OK) but not to use both forms in the same spec file. So this spec is OK in that respect. There is a redundant "/" between $RPM_BUILD_ROOT and %{_bindir} but to block on that would be nit-picking. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review