Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590355 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #2 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-05-11 03:58:44 EDT --- Some initial comments: o In the optflags patch can you remove the -O5 too, %{optflags} already adds -O2. o Please use only on of the forms $RPM_BUILD_ROOT and %{buildroot}. o The package seems to create dirs that are unowned e.g. /usr/share/golly and /usr/share/golly/Rules, please have a look. o I wonder the meaning of this in %build: echo "flags = \'%{optflags}\'" o Check if the standard sf.net source url can be used: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review