Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576685 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-05-10 18:42:56 EDT --- (In reply to comment #10) > Is this made in the right way? Please tell me if I'm doing something wrong or > something that is not allowed to. This is what I would have done: At the end of %install, I would add # Install docs (needed for contrib folder) mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}/contrib install -p AUTHORS ChangeLog ChangeLog.aewm++ ChangeLog.until-0.1.6 LICENSE NEWS README \ %{buildroot}%{_docdir}/%{name}-%{version} install -p contrib/lobo/README contrib/lobo/check.png contrib/lobo/pekwm_autoprop.pl \ contrib/lobo/pekwm_menu_config.pl contrib/lobo/pekwm_menu_config.pl.vars \ contrib/lobo/uncheck.png %{buildroot}%{_docdir}/%{name}-%{version}/contrib and in %files %doc %{_docdir}/%{name}-%{version} But your way is much simpler and works fine too. Nice idea actually. ;) Congratulations, the package is APPROVED. Good work! Please follow the instructions from https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and_Set_Owner and apply for the 'packager' group in the accounts system, so I can sponsor you. If you have problems, don't hesitate to contact me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review