Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589504 --- Comment #11 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-05-10 06:19:23 EDT --- Review: OK: rpmlint must be run on every package. OUTPUT: apache-commons-compress.noarch: W: spelling-error Summary(en_US) bzip -> zip, blip, b zip apache-commons-compress.noarch: W: spelling-error %description -l en_US bzip -> zip, blip, b zip apache-commons-compress.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-compress apache-commons-compress-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese Not a problem. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. Javadocs subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Other problems: * You should not install in %build section. Please just remove the "install -d $MAVEN_REPO_LOCAL" line. * All your symlinks are broken "ln -s %{name}-%{version}.jar" should be "ln -s %{shortname}-%{version}.jar * You should not use %define but %global. See http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define * You can make use of the %{name} macro on a few places (if you want to) - Javadoc subpackage Summary and Description. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review