Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575185 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-05-09 23:57:38 EDT --- Sorry was busy and away last weekend. + is ok - is Needs work Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2176218 + rpmlint output for SRPM and for RPM. python-bunch.src: W: spelling-error %description -l en_US alice -> Alice, slice, alive python-bunch.src: W: spelling-error %description -l en_US bunchify -> bunchy, Bunche, bunch python-bunch.src: W: spelling-error %description -l en_US multi -> mulch, mufti python-bunch.noarch: W: spelling-error %description -l en_US alice -> Alice, slice, alive python-bunch.noarch: W: spelling-error %description -l en_US bunchify -> bunchy, Bunche, bunch python-bunch.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti python-bunch.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/bunch/__init__.py 0644L /usr/bin/env 2 packages and 0 specfiles checked; 1 errors, 6 warnings. ==> All these can be ignored and are false messages. + source files match upstream url (sha1sum) d6f0d0f626218b5c955f233d4d45ef18727ff4ea bunch-1.0.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. - BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no -devel subpackage + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) we can remove build time dependency on dos2unix by using sed in %prep See https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings also good if timestamps are preserved. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review