[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579376

--- Comment #15 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-05-08 20:42:52 EDT ---
The usual advice w.r.t. PERL_INSTALL_ROOT applies -- and I've really _got_ to
nudge Steve to fix cpanspec.

There's a test that skips due to Plack::Loader not being around, but it's an
optional test (and plack isn't likely to be in rawhide yet for a little bit at
least) so I'm not going to call it a blocker.  (Though it would be nice to BR
it when we have plack in.)

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2174696

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Latest version (1.00) is being packaged.

Source tarballs match upstream (sha1sum):
2559eeae78c6bcb2e2d61dd5cadea0c6d11bf229 CGI-Application-PSGI-1.00.tar.gz
2559eeae78c6bcb2e2d61dd5cadea0c6d11bf229 CGI-Application-PSGI-1.00.tar.gz.srpm

Final provides / requires are sane:

====> rpmlint perl-CGI-Application-PSGI.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

======> perl-CGI-Application-PSGI-1.00-1.fc14.noarch.rpm
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(CGI::Application::PSGI) = 1.00
perl-CGI-Application-PSGI = 1.00-1.fc14
====> requires
perl >= 0:5.008_001
perl(:MODULE_COMPAT_5.10.1)  
perl(CGI::PSGI)  
perl(strict)  
====> obsoletes
====> conflicts

======> perl-CGI-Application-PSGI-1.00-1.fc14.src.rpm
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl >= 1:5.8.1
perl(CGI::Application)  
perl(CGI::PSGI)  
perl(ExtUtils::MakeMaker)  
perl(Test::More)  
perl(Test::Requires)  
perl(Test::TCP)  
====> obsoletes
====> conflicts

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]