[Bug 583327] Review Request: clementine - A music player and library organiser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583327

--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-05-08 20:23:08 EDT ---
Alright. I had a discussion with a clementine developer. 
   http://code.google.com/p/clementine-player/issues/detail?id=291

What he says is they made such API breaking modifications in qxt and
qtsingleapplication that are not upstreamable. So far I have been using
clementine-0.2 built against our own qxt and own-to-be qtsingleapplication and
I didn't see any regressions. That is perhaps because I didn't try to use the
functionality that is provided by these modified libraries. Or perhaps the
modifications are made after 0.2 releasei I didn't have much time to play
around with 0.3, I just verified it can do the basic things.

So, in particular, quoting the developer:

* qxt: changes are to add support for media keys (play, stop, etc.) in the
global shortcut library.  I've included a private Qt header in there too, so
these probably wouldn't get accepted upstream.

* qtsingleapplication: changes are twofold: there's an obscure compilation fix
for cross-compilation with mingw in release mode, which we could send upstream,
but the other one is a compatibility-breaking API change.

* universalchardet (new bundled library with 0.3): modified to remove its
dependencies on Mozilla. It's not currently provided separately so the only
solution is to bundle the source with clementine.

qtlsingleapplication and universalchardet are small libraries, so we won't
waste too much space by keeping them bundled. qxt is large originally, but
clementine only bundles a relatively small portion of it.

What do you folks need? Can we make an exception to allow these modified
libraries in clementine?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]