Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590305 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-05-08 16:42:08 EDT --- - rpmlint output is OK. - Non-numeric versioning seems to be allowed in this case, so that's OK. - Please use %{version} macro in Source0 line. (The macro is automatically defined by the Version: tag) - Please don't mix "vile" and "%{name}" in %files, just choose one and stick with it. - This package uses GNU autotools, so a plain make %{?_smp_mflags} will do just fine. - There's optional X and Perl support. I think that they should be added, as well. - Furthermore you must add flex as a BuildRequire: checking for startup path... $(datadir) checking if lex supports %pointer... no configure: WARNING: Your lex program does not support POSIX %pointer. Get flex. checking if lex supports character classes... no configure: WARNING: Your lex program does not support POSIX character classes. Get flex. checking if lex supports options... no configure: WARNING: Your lex program does not support POSIX options. Get flex. checking if lex supports states... lex conftest.l 1>&5 configure: WARNING: disabling build for lex-filters - The license is not clearly defined. A lot of the source files don't have any license headers. The included COPYING file states that ... "it is released under the provisions of the specific version of the GNU General Public License, below." with the rest of the file containing the GPLv2 license. This would make the License: tag GPL+. However, ntwinio.c is explicitly under GPLv2, and regexp.c and vl_*.h under the MIT license. vl_ctype.c, however, doesn't have a license declaration. MIT is compatible with GPL, so GPL+ and GPLv2 makes GPLv2 in total. Please ask upstream to add proper license headers in all the source code files, and also a definition what version of the GPL applies to the distribution. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review