Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590244 --- Comment #2 from Andrea Musuruane <musuruan@xxxxxxxxx> 2010-05-08 09:24:46 EDT --- Let's start with some remarks: - The code is licensed under the MIT license while the icons are licensed as CC-BY. Therefore: # the code is licensed under the MIT license while the icons are licensed as CC-BY License: MIT and CC-BY (adding a comment in the SPEC file is really suggest to avoid further questions). - These explicit Requires are not needed and they must be dropped: Requires: mono-core, gtk-sharp2 - It is not needed to copy SOURCE1 in the top source directory. - You must use desktop-file-install to install desktop files. - Comment and Generic name should be different in desktop files. See Debian package for ideas. - You are using an icon found in an external package without requiring it. Anyway I suggest you to use the icon Debian for consistency. Moreover it is derived from pinta logo. - You are not installing any doc. - Rpmlint output is not clean. You must fix: pinta.x86_64: W: incoherent-version-in-changelog 0.3-2.20100412git ['0.3-1.20100412git.fc12', '0.3-1.20100412git'] pinta.x86_64: W: no-documentation - If you run /usr/bin/pinta you'll get an error stating "Could not open file: ". This is because you are not correctly escaping "$@" when creating the bash script. Debian Pinta pacakge: http://patch-tracker.debian.org/package/pinta/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review