[Bug 578024] Review Request: ingres - Relational DBMS Server and Utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578024

--- Comment #15 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-08 08:40:42 EDT ---
Some easy fix issues:
1.Those lines should be removed from spec
# Requries changes from upstream but can be supported
ExcludeArch:    ia64
# Not officially supported by upstream, but possible with some tweaking
ExcludeArch:    ppc
# As ppc
ExcludeArch:    ppc64
# Unsupported by upstream (although was previously)
ExcludeArch:    S390
# Unsupported by upstream
ExcludeArch:    ARM
# Unsupported by upstream
ExcludeArch:    Parisc
# Unsupported by upstream
ExcludeArch:    SPARC
Requires:       %{_bindir}/sed
Requires:       %{_bindir}/grep
Requires:       /sbin/runuser
Requires:       %{__tar}
Requires:       %{_bindir}/ipcs
Requires:       %{__awk}
2. Add those lines before %prep
%package client
Conflicts: ingres
Summary: Local and remote connectivity servers and utilities

%package server
Requires: %{name}-client = %{version}-%{release}
Summary: DBMS server and utilities

%package devel
Requires: %{name}-client = %{version}-%{release}
Summary: Application development

%package documentation
Summary: Documentation

%description client
Client side runtime and networking components and drivers
ODBC and JDBC drivers

%description server
DBMS server and database utilities

%description devel
Embedded SQL precompilers, headers and appliaction development tools

%description documentation
Full documentation set in PDF format

3.simply use cat and sed instead of %{__cat}  and %{__sed} 

4.%defattr(-,ingres,ingres,-) should always be %defattr(-,root,root,-)

5.%post devel
/sbin/ldconfig %{_libdir}/ingres seems not right
If the shlibs are in the subdirs of %{_lib}, you should add a file to
/etc/ld.so.conf.d

6. Some SPEC references may be useful for you.
http://cvs.fedoraproject.org/viewvc/rpms/mysql/devel/
http://cvs.fedoraproject.org/viewvc/rpms/postgresql/devel/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]