[Bug 589168] Review Request: apache-commons-logging - rename of jakarta-commons-logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589168

--- Comment #16 from Sandro Mathys <sm@xxxxxxxxxxxxxxxx> 2010-05-07 05:56:35 EDT ---
(In reply to comment #15)
> I would say that summary with "rename of <oldpkg>" obviously pointed that this
> is re-review of existing package.

For me it's all clear and not your fault. You also stated that it's a renaming
in the bug's description. But the reviewer MUST state that he's aware of the
fact and that he checked for the special requirements (Provides/Obsoletes) - he
didn't do either.

> I counted only one other problem (thank you for it pointing out btw), if there
> is anything else I missed let me know.

The two problems:
1) Provides didn't use marcos
2) self-obsoletion

...where in your specific case fixing 1) fixes 2)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]