[Bug 589168] Review Request: apache-commons-logging - rename of jakarta-commons-logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589168

Sandro Mathys <sm@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sm@xxxxxxxxxxxxxxxx

--- Comment #14 from Sandro Mathys <sm@xxxxxxxxxxxxxxxx> 2010-05-07 04:17:24 EDT ---
I see here at least two indications that the package renaming process was not
done correctly:
http://fedoraproject.org/wiki/Package_Renaming_Process#Re-review_required

Particularly of importance is this:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages

First, the reviewer never explicitly stated that he's aware of this being a
renaming (and obviously wasn't) and second the Provides doesn't use macros.

Also, this is _no_ false positive but a real problem:
apache-commons-logging.noarch: W: self-obsoletion jakarta-commons-logging <=
0:1.0.4 obsoletes jakarta-commons-logging = 0:1.0.4

Now that the reviewer wasn't aware it's been a renaming doesn't matter as I
filled that gap (and am well aware of it). But please correct the other two
problems before you push this pkg to any repo.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]