Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588194 Ankur Sinha <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-05-07 01:06:59 EDT --- hey, a quick review: [Package@Ankur SPECS]$ rpmlint quickly.spec ../SRPMS/quickly-0.4.2-1.fc11.src.rpm quickly.src: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging quickly.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging 1 packages and 1 specfiles checked; 0 errors, 2 warnings. ## Looking at the spec ## - Aren't you going to build and install separately? %build CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build This way the correct build flags will be used. - For the %install section too, please replace "python" by "%{__python}". - add brackets to %name for %find_lang. - whats line 37 for? - use something on the lines of %{python_sitelib}/nautilus_pastebin-*-py?.?.egg-info for egg info, its just a little more informative. I'll do a detailed review within the week, hopefully. regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review