Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Date-Holidays - Driver based class to calculate holidays Alias: pear-Date-Holidays https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210788 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-10-29 00:15 EST ------- * source files match upstream: 84dcf7f0c92afdf08b9c1d761a8ca89f Date_Holidays-0.16.1.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(Date_Holidays) = 0.16.1 php-pear-Date-Holidays = 0.16.1-1.fc7 = /bin/sh /usr/bin/pear /usr/bin/php php-pear(Console_Getargs) php-pear(Date) php-pear(PEAR) php-pear(XML_Serializer) * %check is not present. Test suite run manually and all tests pass: TestCase Date_Holidays_TestSuite->testFactory() passed TestCase Date_Holidays_TestSuite->testFactoryISO3166() passed TestCase Date_Holidays_Driver_TestSuite->testAddCompiledTranslationFile() passed TestCase Date_Holidays_Driver_TestSuite->testAddTranslationFile() passed TestCase Date_Holidays_Driver_TestSuite->testIsHoliday() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidays() passed TestCase Date_Holidays_Driver_TestSuite->testGetHoliday() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidayDate() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidayDates() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidayForDate() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidayProperties() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidaysForDatespan() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidayTitle() passed TestCase Date_Holidays_Driver_TestSuite->testGetHolidayTitles() passed TestCase Date_Holidays_Driver_TestSuite->testGetInternalHolidayNames() passed TestCase Date_Holidays_Driver_TestSuite->testGetYear() passed TestCase Date_Holidays_Driver_TestSuite->testSetYear() passed TestCase Date_Holidays_Driver_Christian_TestSuite->testHolidays2005() passed TestCase Date_Holidays_Driver_Germany_TestSuite->testHolidays2005() passed TestCase Date_Holidays_Driver_Germany_TestSuite->testHolidays2006() passed TestCase Date_Holidays_Driver_Germany_TestSuite->testHolidays2005stampsAndSavingsDay() passed TestCase Date_Holidays_Driver_Jewish_TestSuite->testHolidays2005() passed TestCase Date_Holidays_Driver_PHPdotNet_TestSuite->testHolidays2005() passed TestCase Date_Holidays_Driver_UNO_TestSuite->testHolidays2005() passed TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays_2005() passed TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays_2004() passed TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays_2006() passed TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays() passed TestCase Date_Holidays_Driver_Sweden_TestSuite->testHolidays2005() passed TestCase Date_Holidays_Driver_Sweden_TestSuite->testHolidays2006() passed TestCase Date_Holidays_Driver_Sweden_TestSuite->testGermanTranslations() passed TestCase Date_Holidays_Driver_Sweden_TestSuite->testcompiledGermanTranslations() passed * owns the directories it creates. (/usr/share/pear/Date is owned by a dependency). * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (pear module installation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review