Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589479 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2010-05-06 13:51:18 EDT --- GOOD: + Package name fullfill naming guidelines. + URL tag contains proper project home page. + Package contains most recent release of the software. + Could download source file via spectool -g + Consistantly rpm macro usages. + License tag contains proper OSS licenses + Package has proper BuildRoot definition. + Package contains versioned MODULE_cOMPAT_ Req. + Package contains no subpackages + Build use RPM_OPT_FLAGS + Build use SMP flags + Local build works fine. + Mockbuild works fine. + Build on koji works fine. + Packaged sources matches with upstream. * Rpmlint has no complains about the binary package + Rpmlint has no complains about the debuginfo package + Debuginfo package contains sources + %files stanza use rpm macros + %files has proper attributes + All files of the package belong to the package + Package contains no files belog to an other package + %doc stanza is small, so we ne no extra doc subpackage + Package has proper %ChangeLog BAD: - Package contains no verbatin copy of the license text. - Package has no %clean section, so it's only valid for F-13 and devel - Rpmlint shows warnings for the source RPM_OPT_FLAGS$ rpmlint perl-Compress-Raw-Lzma-2.028-1.fc12.src.rpm perl-Compress-Raw-Lzma.src: W: no-cleaning-of-buildroot %clean perl-Compress-Raw-Lzma.src: W: no-%clean-section 1 packages and 0 specfiles checked; 0 errors, 2 warnings. - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review