Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585467 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(tomspur@fedorapro | |ject.org) | --- Comment #17 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-05-06 12:11:14 EDT --- (In reply to comment #16) > I tried above patch on my F-13 machine and see its showing in installed > extensions but also saw showing "Not compatible with SeaMonkey 2.0.4". So If > its not going to work in SeaMonkey then better not to include it in SPEC. Oh, right... (As noted above not tested, just it's showing up^^) Maybe it's worth to suround a conditional around the seamonkey part, so it can easily enabled/disabled. Don't know if it will ever be working with seamonkey (I don't use seamonkey anyway, just wanted to note, that some user want to have that part...) --- mozilla-googlesharing.spec 2010-05-06 18:09:50.058954346 +0200 +++ orig 2010-05-04 13:17:56.714392098 +0200 @@ -4,11 +4,9 @@ %global src_ext_id googlesharing@xxxxxxxxxxxxxxxxxxxxxxxxxx %global inst_dir %{moz_extensions}/%{firefox_app_id}/%{src_ext_id} -%global seamonkey_app_dir \{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a} +%global seamonkey_app_dir \{googlesharing} %global sym_link_dir %{moz_extensions}/%{seamonkey_app_dir} -%global with_seamonkey 0 - Name: mozilla-googlesharing Version: 0.18 Release: 5%{?dist} @@ -60,10 +58,8 @@ popd # symlink from seamonkey extension to firefox extension -%if 0%{?with_seamonkey} mkdir -p %{buildroot}%{sym_link_dir} ln -s %{inst_dir} %{buildroot}%{sym_link_dir} -%endif %clean %{__rm} -rf $RPM_BUILD_ROOT @@ -72,9 +68,7 @@ %defattr(-,root,root,-) %doc COPYING %{inst_dir} -%if 0%{?with_seamonkey} %{sym_link_dir} -%endif %changelog -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review