Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589168 --- Comment #6 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-05-06 09:11:27 EDT --- Review: OK: rpmlint must be run on every package. Output: apache-commons-logging.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, untimely apache-commons-logging.noarch: W: self-obsoletion jakarta-commons-logging <= 0:1.0.4 obsoletes jakarta-commons-logging = 0:1.0.4 apache-commons-logging.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-logging False positives. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. NOTOK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. I don't see a reason why not using default %defattr(-,root,root,-) >From the guidelines: Unless you have a very good reason to deviate from that, you should use %defattr(-,root,root,-) for all %files sections in your package. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Please drop Package from the Summary. Also javadoc subpackage will be better tohave a description like "API documentation for %{name}." Please also use the default the permissions. I know that they will match in this case but we should use the defaults. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review