Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555059 --- Comment #22 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-05 11:42:27 EDT --- Again please change the release number every time you modify your spec file to avoid confusion. For -2: * BR: - Would you explain why "BR: autoconf automake" is needed? No autotools seem to be called during build process. * BuildRoot - For Fedora BuildRoot is no longer needed. * Macros - Again: > - Use %{_initddir} instead of %{_initrddir}: > https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_filesystem * Useradd - Change the comment 'User to own clamsmtp directories and default processes' for "clamsmtp" to be more specific to clamsmtp * Comments in scriptlets - Please remove #%postun comments completely. These comment now appears in %preun scriptlet (please check $rpm -q --scripts clamstmp) and are very confusing. * rcsysv scripts issue again - /etc/rc.d/init.d/clamsmtpd says: ------------------------------------------------------------------- 29 # The location for pid file 30 piddir=/var/run/clamav ------------------------------------------------------------------- However: ------------------------------------------------------------------- # rpm -qf /var/run/clamav error: file /var/run/clamav: No such file or directory ------------------------------------------------------------------- - Again: > - My system does not have "clamav" group. clamav-filesystem seem to > create "clamupdate" user/group instead. - clamd-clamsmtp service seems badly broken. For example: -------------------------------------------------------------------- [root@localhost ~]# service clamd-clamsmtp status clamd.clamsmtp is stopped [root@localhost ~]# service clamd-clamsmtp start Starting clamd.clamsmtp: LibClamAV Warning: ************************************************** LibClamAV Warning: *** The virus database is older than 7 days! *** LibClamAV Warning: *** Please update it as soon as possible. *** LibClamAV Warning: ************************************************** [ OK ] [root@localhost ~]# service clamd-clamsmtp status clamd.clamsmtp dead but subsys locked [root@localhost ~]# ps auwwx | grep [c]lamd clamsmtp 20758 0.0 10.9 96264 82408 ? Ssl 00:22 0:00 clamd.clamsmtp -c /etc/clamd.d/clamsmtp.conf --pid /var/run/clamd.clamsmtp/clamd.pid -------------------------------------------------------------------- Actually with "service clamd-clamsmtp start", clamd.clamsmtp starts, however "service clamd-clamsmtp status" cannot find clamd.clamsmtp process. - /etc/logrotate.d/clamsmtp issue is not yet fixed. ( i.e. this file contains: --------------------------------------------------------------------- 6 postrotate 7 killall -HUP clamd.clamsmtp 2>/dev/null || : 8 endscript --------------------------------------------------------------------- however killall -HUP clamd.clamsmtp does not do anything. See the explanation in my previous comment ) Please check if 2 rcsysv scripts work correctly, and fix other things raised above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review