Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568315 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |terjeros@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #6 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-05-03 16:21:26 EDT --- I finally understood how to use the tool and it was in fact clever, thanks. ? rpmlint xapply-debuginfo.x86_64: E: wrong-script-interpreter /usr/src/debug/xapply-3.4/x apply-3.4/bin/xapply/xapply.m mkcmd xapply-debuginfo.x86_64: E: non-executable-script /usr/src/debug/xapply-3.4/xapply-3.4/bin/xapply/xapply.m 0644 mkcmd Can be ignored? ok naming of package and spec ! spec file use version macro in Source0 and %prep add some comments in %build, a (future) new maintainer will be very confused about that mess. more explicit here please: %{_mandir}/man1/* add some of the README/TODO files to %doc ! license approved and tag correct I can't find any thing about license, where did you get BSD from? ok license in %doc ok correct language ok sha1sum on sources and ok url 3e5a6a01c7fc1c27b1ec68fd607563ba0400f3cb xapply-3.4.tgz 3e5a6a01c7fc1c27b1ec68fd607563ba0400f3cb xapply-3.4.tgz.spec ef87e01d407b8e1919fe0099bb53a8bca5475bec msrc0-0.7.tgz ef87e01d407b8e1919fe0099bb53a8bca5475bec msrc0-0.7.tgz.spec 33342afc845db84a040f116202b880d37b9f626f mkcmd-8.14.tgz 33342afc845db84a040f116202b880d37b9f626f mkcmd-8.14.tgz.spec ok koji build with correct buildreq http://koji.fedoraproject.org/koji/taskinfo?taskID=2158029 ok excludearch - locale files - ldconfig ok no bundling ok owns, dirs and perms and only once ok macros ok code or content - large docs ok %doc not affect the runtime - headers|static in devel|static - .so in devel - devel dep on base - no .la|.a file - gui with desktop file ok own just not owned ok utf-8 file names ok trans ok testing - scriptlets sane - subpkgs dep on base - pkgconfig(.pc) in devel - req on package not on files ok add man pages Please have a look at the ! stuff above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review