Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588202 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-05-03 05:04:33 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2157259 + rpmlint output for SRPM and for RPM. perl-Class-ISA.src: W: spelling-error %description -l en_US Fishstick -> Fish stick, Fish-stick, Matchstick perl-Class-ISA.src: W: spelling-error %description -l en_US superclasses -> super classes, super-classes, underclasses perl-Class-ISA.noarch: W: spelling-error %description -l en_US Fishstick -> Fish stick, Fish-stick, Matchstick perl-Class-ISA.noarch: W: spelling-error %description -l en_US superclasses -> super classes, super-classes, underclasses ==> Ignore this. + source files match upstream url (sha1sum) e487f1b896151d0dbd8b9ed79f918b0d00b7822d Class-ISA-0.36.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=4, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.01 cusr 0.01 csys = 0.05 CPU) + Package perl-Class-ISA-0.36-1.fc14.noarch => Provides: perl(Class::ISA) = 0.36 Requires: perl >= 1:5 perl(if) perl(strict) perl(vars) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review