Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585902 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-05-03 04:42:07 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2156995 + rpmlint output for SRPM and for RPM. cardpeek.src: W: spelling-error %description -l en_US extendable -> expendable, extend able, extend-able cardpeek.src: W: invalid-url Source0: http://cardpeek.googlecode.com/files/cardpeek-0.5.tar.gz HTTP Error 404: Not Found cardpeek.x86_64: W: spelling-error %description -l en_US extendable -> expendable, extend able, extend-able ==> Ignore this. + source files match upstream url (sha1sum) 0d5cb13821b21ca6367d26b16f447f2ad6b75b82 cardpeek-0.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + gtk-update-icon-cache scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file is present and installed correctly. + A GUI application. Suggestions:- 1) As per http://lists.fedoraproject.org/pipermail/devel/2010-March/133523.html, you need to add in desktop file StartupNotify=true 2)it will be good if patch cardpeek-executable-stack.patch would have committed in upstream first. Have you contacted upstream personally to include this patch besides submitting it as an issue? 3) To keep timestamps of files getting installed from tarball, you should use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 4)also, you can add to %description The tool currently reads the contents of : * EMV cards * Calypso public transport cards (such as Navigo) * Moneo ePurse cards * Vitale 2 French health cards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review