Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 ------- Additional Comments From pertusus@xxxxxxx 2006-10-26 19:01 EST ------- * Regarding the user, I'd prefer a patch such that it doesn't silently fail if the user name change or something along (at least in the code, in the documentation, I don't care). * Requires(pre): /sbin/nologin isn't needed, useradd don't fail even if the shell don't exist and it is in util-linux. useradd I don't know. Maybe it is needed for proper ordering, but it is not obvious since rpm depends on it. * xttpd user may be deleted at the uninstall since he shouldn't own any directory (nor any file). * Regarding the init file, if you want to have the message on the same line that the 'starting message', no problem but currently there is an additional end of line, so it isn't clear what failed. In my opinion, the code should be (added -n for the first echo) echo -n $"PORT environment is not set." failure echo RETVAL=1 return $RETVAL * from a look at the code it seems that the group isn't changed, it should be. And also if setuid fails, there is only a log, the program should exit. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review