Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 ------- Additional Comments From nicolas.mailhot@xxxxxxxxxxx 2006-10-26 17:42 EST ------- 1. still missing the root dir ownership, will leave dangling dirs when removed. Please add %dir %{_datadir}/icons/Echo (not too fond of using caps in names BTW) 2. a lot of people like to keep %build, if only to document it was intentionaly left empty (also I think in some cases pulling it triggers rpm bugs) 3. explicitly copying LICENSE is not necessary, %doc does it for you 4. I would recommend keeping any gtk2 dep out - much better to have a clean spec people can safely copy. Evetyone will forget why Echo was special soonish (please add a comment before the redhat-artwork dep) 5. when copying static data it's usually better to preserve original timestamps [shameless style preference plug, feel free to ignore) 6. you should know it's possible to replace $RPM_BUILD_ROOT with a leaner %{buildroot} http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review