Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510464 --- Comment #13 from Chen Lei <supercyper@xxxxxxx> 2010-05-01 06:18:50 EDT --- Some comment: 1.%{__gzip} $RPM_BUILD_ROOT%{_mandir}/man1/gns3.1 is not needed, rpmbuild will automaticlly gzip all manpages. 2. GNS3 should requires dynamips 3. Source0: http://downloads.sourceforge.net/sourceforge/gns-3/%{real_name}-%{version}-src.tar.bz2 -> http://downloads.sourceforge.net/gns-3/%{real_name}-%{version}-src.tar.bz2 See https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net 4.Requires: PyQt4 sip Require PyQt4 is enough, pyqt4 will automaticlly picks up sip 5.please explain why you install pemubin.py to %{_datadir} All other things I see is fine. Note: wine is not a emulator, it only provides some windows APIs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review