Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584974 --- Comment #2 from josef radinger <cheese@xxxxxxxxxxxxxx> 2010-04-30 14:40:01 EDT --- (In reply to comment #1) > Having no answer from you on the devel mailing-list I only went quickly through > this package. > > There are the few remarks I have: > - Fix version > The version of this package is 0.0.7 not 0.0 cf > http://fedoraproject.org/wiki/Packaging:R#R_version > (Why did you change compare to R-bitops ?) fault on my side i found the problem and forgot to fix it on all packages fixed > - Fix %check > Package builds fine with the %check here agreed and fixed > - Fix %changelog > Please update the format of the changelog, the version-release should be on > the same line as the changelog entry. > This point is valid for at least R-bitops to. http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs states that this format is valid, too. I prefer this as i often build on very small resolution-screens and would have to scroll otherwise. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review