Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 ------- Additional Comments From luya_tfz@xxxxxxxxxxxxxxxx 2006-10-26 15:51 EST ------- (In reply to comment #9) > We have generally not added a gtk2 dependency for running gtk-update-icon-cache > in other packages, and the packaging guidelines also discourage it. > Should I add coreutils Requires(post) and Requires(postun)? I looked to the link posted on comment #5 and noticed coreutils is omitted. > The description should be one or more complete sentences. Fixed (In reply to comment #10) > Also, it should not be too hard to find a safe %defattr mask Not sure how to proceed as I haven't touched that line for awhile. Could you give an example? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review