[Bug 587320] Review Request: gnome-icon-theme-symbolic - Symbolic GNOME icons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587320

--- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-04-29 16:31:12 EDT ---
Some more informal comments:

Requires(posttrans): gtk2 >= 2.6.2
Requires(postun): gtk2 >= 2.6.2

I believe we generally don't add this as a dep (thats one of the reasons for
the ||: construct)



%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT

The rm -rf is no longer needed in %install



%clean
rm -rf $RPM_BUILD_ROOT

And neither is %clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]