Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559552 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-04-28 10:09:18 EDT --- MUST: naming, should follow pre-release naming guidelines, and use something like Release: 0.1.beta2 MUST: %build, use -no-separate-debug-info build option, so that the usual -debuginfo pkg makes sense SHOULD: add runtime dependency, %{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}} licensing: should be License: LGPLv2+ $ rpmlint *.rpm x86_64/*.rpm qca-pkcs11.src: W: spelling-error Summary(en_US) Smartcard -> Smart card, Smart-card, Smartness qca-pkcs11.src: W: spelling-error %description -l en_US pkcs -> pecs, pics, pk cs qca-pkcs11.src: W: spelling-error %description -l en_US smartcard -> smart card, smart-card, smartness qca-pkcs11.src: W: spelling-error %description -l en_US decryption -> encryption, deception, description qca-pkcs11.src:36: W: configure-without-libdir-spec qca-pkcs11.x86_64: W: spelling-error Summary(en_US) Smartcard -> Smart card, Smart-card, Smartness qca-pkcs11.x86_64: W: spelling-error %description -l en_US pkcs -> pecs, pics, pk cs qca-pkcs11.x86_64: W: spelling-error %description -l en_US smartcard -> smart card, smart-card, smartness qca-pkcs11.x86_64: W: spelling-error %description -l en_US decryption -> encryption, deception, description qca-pkcs11-debuginfo.x86_64: W: spelling-error Summary(en_US) pkcs -> pecs, pics, pk cs qca-pkcs11-debuginfo.x86_64: W: spelling-error %description -l en_US pkcs -> pecs, pics, pk cs 3 packages and 0 specfiles checked; 0 errors, 11 warnings. patches: please document the need for qca-pkcs11.cpp.vsnprintf.patch , and please consult upstream. The rest looks pretty simple and clean. address these items, and I think we have a winner. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review