Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582974 --- Comment #9 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-04-27 06:40:12 EDT --- Created an attachment (id=409430) --> (https://bugzilla.redhat.com/attachment.cgi?id=409430) Patch to fix few more cleanups of SPEC as per guidelines. Few more things you need to do in SPEC are 1) Usage of macro style for install should be dropped or macros should be written for rm command also. 2) /usr/bin should be replaced with its macro %{_bindir} ==> See https://fedoraproject.org/wiki/Packaging/Guidelines#Macros 3) we generally don't want to keep file extension to files being copied to /usr/bin so install dnsenum.pl as dnsenum only Add Changelog and submit new SPEC and SRPM for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review