Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 ------- Additional Comments From miker5slow@xxxxxxxxxxxxx 2006-10-25 17:46 EST ------- Your source doesnt match upstream for Source0: I would use the link to the source, then wget -N the source or use spectool -g on the spec file and get it. You should rename the spec to echo-icon-theme.spec as rpmlint complains about the current name coreutils isnt needed to require: http://fedoraproject.org/wiki/Extras/FullExceptionList personally I think you should use cp and mkdir instead of the macros for them You seem to be putting the license in 2 times Once when you do %{__cp} LICENSE $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version} and then again in the %docs section Maybe a couple other things when I get home and can look it over better. Also I filed a bug about the creative commons not being in rpmlint: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211417 just incase you want to watch for when it is fixed/updated -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review