Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225670 --- Comment #5 from Adam Tkac <atkac@xxxxxxxxxx> 2010-04-26 07:25:27 EDT --- rpmlint output is so long so it will be confusing to paste it here. There are many false positives, as written in comment #4, because cups is very specific package. Following rpmlint issues should be addressed: cups.src:259: W: macro-in-comment %patch28 cups.src: W: patch-not-applied Patch28: cups-gnutls-gcrypt-threads.patch ^^^ please apply the patch or remove it cups.x86_64: W: obsolete-not-provided LPRng ^^^ I think LPRng should be provided cups.x86_64: W: file-not-utf8 /usr/share/doc/cups-1.4.3/CREDITS.txt ^^^ Please convert this file to UTF-8 during build process. `man 1 iconv` is your friend cups-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libcupscgi.so.1 exit@xxxxxxxxxxx ^^^ Please explain why it is acceptable (for example self-implemented stack protector is a good reason to call exit inside library) cups-lpd.x86_64: W: spelling-error %description -l en_US provices cups-php.x86_64: W: spelling-error %description -l en_US provices ^^^ Probably typos Remaining issues from comment #1: The PIE problem: - per buildlog --enable-pie does nothing: ./configure ... ... configure: WARNING: unrecognized options: ..., --enable-pie, ... ... - it seems you use -pie/-fpie flags wrongly. You use only -fPIE during linking which is wrong. You should use -fPIE during compilation and -pie during linking. `man 1 gcc` clearly says: " -pie Produce a position independent executable on targets which support it. For predictable results, you must also specify the same set of options that were used to generate code (-fpie, -fPIE, or model suboptions) when you specify this option. " - to be precise please use -fpie during compilation on all platforms except sparcv9 sparc64 s390 and s390x. In "bind" specfile there are following lines: # Sparc and s390 arches need to use -fPIE %ifarch sparcv9 sparc64 s390 s390x for i in bin/named{,-sdb}/{,unix}/Makefile.in; do sed -i 's|fpie|fPIE|g' $i done %endif I don't see other problems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review