Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570457 --- Comment #7 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-04-26 03:49:51 EDT --- Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-2.fc12.src.rpm (In reply to comment #3) > Some notes: > > * (Build)Requires > - The following Requires are all not needed. These are for development > dependencies, not for runtime: > ------------------------------------------------------------ > Requires: rubygem(rubyforge) >= 2.0.3 > Requires: rubygem(gemcutter) >= 0.3.0 > Requires: rubygem(hoe) >= 2.5.0 > ------------------------------------------------------------ > > - The correct dependency should be "rubygem(right_http_connection)" FIXED. > > - As lib/right_rackspace.rb contains: > ------------------------------------------------------------ > 29 require 'json' > ------------------------------------------------------------ > This package should have "Requires: rubygem(json)" FIXED. > > * %check > - As this package contains test/ directory, please add %check > section and execute some test program there. NACK. This is not possible, because you need to supply your RackSpace credentials into test file. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review