Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wvs-data - World Vector Shoreline data https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212258 ------- Additional Comments From pertusus@xxxxxxx 2006-10-25 17:19 EST ------- * rpmlint gives an ignorable W: wvs-data no-documentation * match upstream 56325c8105c7137ced73396f2f2d8221 wvs.tar.bz2 * simple large data package Please rename the directory with a name without xtide, since it is not really related to xtide. The most logical would be to use %{_datadir}/wvs-data APPROVED if you do that change. No need to reupload a src.rpm, just import it right after doing the change, this is pretty big. In files, I prefer to add a trailing / for directories, to show that it is a directory and not a file (not a blocker). It may be a good idea to add, in a comment in the spec file references to the NOAA site: http://www.ngdc.noaa.gov/mgg/fliers/93mgg01.html http://www.ngdc.noaa.gov/mgg/global/relief/ETOPO5/BOUNDARY/WVS/ (Not a blocker). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review