Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225834 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |NEW CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-04-25 18:09:20 EDT --- - The devel package only contains text files -> can be noarch - Don't use %define inside a macro (first line). It would be better, if you'd use the macro from: https://fedoraproject.org/wiki/Packaging:Python#Macros - Please use parallel make: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - When building I get: ***************************************************************************** *** WARNING: You are using a deprecated build system (autotools). *** You should be using WAF instead; see the file INSTALL.WAF. *** The autotools build system will be removed in a future version. ***************************************************************************** - Please preserve timestamps: make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' - I don't see atm what the '%defattr(644,root,root,755)' in some %files sections do... Can this be left out? - Could you please be consistend with python2-devel vs python-devel? e.g. BR python2-devel, but the devel subpackage R python-devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review