[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=584111

--- Comment #9 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-04-25 17:31:16 EDT ---
- The line
 %define version 1.2a
is redundant. The Version tag already defines the macro %{version}.

- The line
 %{_mandir}/*/*
is a bit too general. Be more verbose. Use wildcards only when necessary, since
they may end up owning things that they're not supposed to.

- The original spec you used was 1.2a-1. Your first should have been 1.2a-2,
and the second one 1.2a-3. So the next version-release should be 1.2a-4.
Rectify this.

- When you do the above, indicate what you have changed in the releases in the
changelog.

- Note that the changelog is still not in the correct format. See
fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]