[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581723

ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #12 from ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> 2010-04-24 19:28:59 EDT ---
Here is the review:

MUST Items:
[X] MUST: rpmlint must be run on every package.
No error/warning except the spelling issues mentioned above that can be
ignored. debug package is OK.
[X] MUST: The package must be named according to the Package Naming Guidelines.
[X] MUST: The spec file name must match the base package %{name}
[X] MUST: The package must meet the Packaging Guidelines.
[X] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
GPLv2+
[X] MUST: The License field in the package spec file must match the actual
license.
See LICENSE file, and comments on source code are OK about the license
[W] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[X] MUST: The spec file must be written in American English.
[X] MUST: The spec file for the package MUST be legible.
[X] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
ff1d0a660727d358364134828fed1a16 → both for embedded archive and downloaded one
[X] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
OK:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2135293
http://koji.fedoraproject.org/koji/taskinfo?taskID=2135291
(Ok also for F11 and F14)
[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[X] MUST: All build dependencies must be listed in BuildRequires
[N/A] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro.
[N/A] MUST: Every binary RPM package which stores shared library files (not
just symlinks) in any of the dynamic linker's default paths, must call ldconfig
in %post and %postun.
[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A package must not contain any duplicate files in the %files
listing.
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[OK] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[OK] MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.
[OK] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[N/A] MUST: Large documentation files should go in a doc subpackage.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[N/A] MUST: Header files must be in a -devel package.
[N/A] MUST: Static libraries must be in a -static package.
[N/A] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[N/A] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[N/A] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
[N/A] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[N/A] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[OK] MUST: Packages must not own files or directories already owned by other
packages.
[OK] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[OK] MUST: All filenames in rpm packages must be valid UTF-8.

This package is APPROVED :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]