Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585467 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #3 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-04-24 15:45:42 EDT --- I'm no sponsor, but here are a few comments: - You install it a bit strange, and I didn't expect it to build cleanly because of the 'cd -'... It would be better, if you use pushd and popd like: pushd chrome/content/ install -Dpm 644 addEditProxy.js googlesharing.js options.js addEditProxy.xul googlesharing.xul options.css options.xul %{buildroot}%{inst_dir}/chrome/content/ popd With pushd you go into the folder and with popd to the folder, you came from. Looks nicer and should be a bit more sane. - Please overwrite the spec file on githup and don't add something like '-v2'. Old versions will be available throught olg src.rpms. If you want to also keep the old versions, please make a subfolder for each version or something like that. - What about seamonkey? Does this programm works with that too? There are some additional folders needed for that and *maybe* that's it. Here is an example in mozilla-noscript, which works well: http://cvs.fedoraproject.org/viewvc/devel/mozilla-noscript/mozilla-noscript.spec?view=markup - There won't be a debuginfo package, because you have BuildArch: noarch, so you can delete: %define debug_package %{nil} - $ rpmlint mozilla-googlesharing-0.18-2.fc13.src.rpm noarch/mozilla-googlesharing-0.18-2.fc13.noarch.rpm mozilla-googlesharing.src: W: spelling-error Summary(en_US) Anonymizing -> Anonymity, Anatomizing, Anonymous mozilla-googlesharing.src: W: spelling-error Summary(en_US) google -> Google, goggle, googly mozilla-googlesharing.src: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-googlesharing.src: W: spelling-error %description -l en_US google -> Google, goggle, googly mozilla-googlesharing.src: W: spelling-error %description -l en_US unredirected -> redirection, misdirected, unrestricted mozilla-googlesharing.noarch: W: spelling-error Summary(en_US) Anonymizing -> Anonymity, Anatomizing, Anonymous mozilla-googlesharing.noarch: W: spelling-error Summary(en_US) google -> Google, goggle, googly mozilla-googlesharing.noarch: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-googlesharing.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly mozilla-googlesharing.noarch: W: spelling-error %description -l en_US unredirected -> redirection, misdirected, unrestricted 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Using Google would reduce 4 warnings, the rest seems unavoidable... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review