Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576839 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review? --- Comment #6 from Steve Traylen <steve.traylen@xxxxxxx> 2010-04-24 12:37:07 EDT --- Review: bdii Date: Apr 24th 2010 * PASS: rpmlint output $ rpmlint SPECS/bdii.spec \ RPMS/noarch/bdii-5.1.0-1.fc13.noarch.rpm \ SRPMS/bdii-5.1.0-1.fc13.src.rpm SPECS/bdii.spec: W: invalid-url Source0: bdii-5.1.0.tar.gz bdii.noarch: E: incoherent-subsys /etc/rc.d/init.d/bdii bdii-update bdii.noarch: E: incoherent-subsys /etc/rc.d/init.d/bdii bdii-slapd bdii.src: W: invalid-url Source0: bdii-5.1.0.tar.gz 2 packages and 1 specfiles checked; 2 errors, 2 warnings. which is all okay. * PASS: Named according to the Package Naming Guidelines. * PASS: spec file name same as base package %{name}. * PASS: Packaging Guidelines. yes. * PASS: Approved license in .spec file. yes ASL 2.0 * PASS: License on Source code. * PASS: Include LICENSE file or similar if it exist. copywright. * PASS: Written in American English. * PASS: Spec file legible. * PASS: Included source must match upstream source. * PASS: Build on one architecture. * PASS: Not building on an architecture must highlighted. * PASS: Build dependencies must be listed in BuildRequires. * PASS: Handle locales properly. no locales * PASS: ldconfig must be called on shared libs. None * PASS: No bundled copies of system libraries. None * PASS: Package must state why relocatable if relocatable. Not * PASS: A package must own all directories that it creates Yes. * PASS: No duplicate files in %files listings. * PASS: Permissions on files must be set properly. %defattr * PASS: %clean section contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). * PASS: Each package must consistently use macros. * PASS: The package must contain code, or permissable content. * PASS: Large documentation files must go in a -doc subpackage. * PASS: %doc must not affect the runtime of the application. * PASS: Header files must be in a -devel package. * PASS: Static libraries must be in a -static package. * PASS: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' * PASS: Then library files that end in .so * PASS: devel packages must require the exact base package * PASS: No .la libtool archives * PASS: GUI apps should have %{name}.desktop file * PASS: No files or directories already owned by other packages. * PASS: %install must run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). * PASS: All filenames in rpm packages must be valid UTF-8. Summary: Just the comments in the previous comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review