Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584220 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-04-21 14:35:01 EDT --- Review: Good: - name ok - %build ok - %{optflags} there - %clean there - %install ok - %files ok - noarch not possible - builds in koji (without BR setuptools): http://koji.fedoraproject.org/koji/taskinfo?taskID=2130784 - no .la - no libs - no devel files - license ok (MIT) - sources match upstream: 97c75039a67593d3f5375fb77f73bbe7 - rpmlint same as posted above, it would be nice to avoid some spelling-errors, but they don't look 'wrong' to me. -> Ignorable Needswork: - BR: python-setuptools is not needed (the egg is builded by distutils) - The %{__rm} is a matter of taste - looks not that good... ############################################################################### Just one should: remove BR: python-setuptools ############################################################################### APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review