Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583949 --- Comment #2 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-04-21 10:38:08 EDT --- (In reply to comment #1) > Bad things (need fixing): > MUST: The sources used to build the package must match the upstream source, as > provided in the spec URL. > ->The files are the same, but they have different timestaps. (use wget -N to > keep timestamps) It should be fixed right now. > MUST: All build dependencies must be listed in BuildRequires, except for any > that are listed in the exceptions section of the Packaging Guidelines > ->According to https://fedoraproject.org/wiki/Packaging:Ruby, Ruby packages > must require ruby at build time with a BuildRequires: ruby. Fixed. Thanks for noticing me. > MUST: Large documentation files must go in a -doc subpackage. > ->Think about creating a -doc subpackage. But it is not necessary IMHO is not necessary and not obvious in Ruby gem packaging. Documentation is always shipped with gem. > SHOULD: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. I asked upstream for this. According to rubyforge site, licence should be correct. > rpmlint output: > rubygem-xml-simple.noarch: E: script-without-shebang > /usr/lib/ruby/gems/1.8/gems/xml-simple-1.0.12/lib/xmlsimple.rb > ->xmlsimple.rb should not be set with executable permissions. Fixed. ------------ Spec URL: http://mifo.sk/RPMS/rubygem-xml-simple.spec SRPM URL: http://mifo.sk/RPMS/rubygem-xml-simple-1.0.12-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review