[Bug 578290] Review Request: mj - Mah-Jong program with network option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578290

Klaus Grue <grue@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |grue@xxxxxxx

--- Comment #14 from Klaus Grue <grue@xxxxxxx> 2010-04-19 15:06:25 EDT ---
Tasaka> To Klaus:
Tasaka> As you are sponsored, you can formally review this. Would you
Tasaka> want to do so?

I will try to take it from here. Thanks for your help.

Now I think only two issues remain:

As Mamoru Tasaka mentioned, the non-GPL tiles must be removed:
https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code

When I read the spec again for consistent use of macros, this caught my eye:
  %files
  ...
  %_bindir/*
  %_mandir/man1/*
I suppose those lines say that mj owns everything in bin and man1.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]