Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583643 --- Comment #3 from Matej Cepl <mcepl@xxxxxxxxxx> 2010-04-19 12:06:00 EDT --- (In reply to comment #2) > ??: The License field in the package spec file must match the actual license. > ==> How can you tell it's GPLV3+ rather than GPLV3? You're right. All GPLv3 are GPLv3+. > A couple of questions: > - Why do you export LANG=en_IE.utf-8 before running ant? (Why in general, and > also why Ireland specifically?) I usually use en_IE.utf-8 locale when I want "normal English", because it is metric, uses A4 paper, EUR money etc. I will leave there en_US to satisfy you're US-centrism ;) and so that I have English error messages. Hopefully it doesn't bother anybody. > - Why not name the directory in the tarball tigase-xmltools-3.3.4 instead of > xmltools so you don't have to do the %setup -n part? good point, fixed > - What's up with the FIXME comment? removed ... will be important in further subsequent packages in stack. Not here. New package is http://mcepl.fedorapeople.org/rpms/tigase-xmltools-3.3.4-2.el6.src.rpm, SPEC file is in the same place. Built in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2126261 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review