[Bug 537366] Review Request: cgal-python - Python bindings for the CGAL library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537366

--- Comment #16 from Chen Lei <supercyper@xxxxxxx> 2010-04-19 07:45:47 EDT ---
(In reply to comment #15)
> Well, I made the modifications and now the egg-info is being build for 
> rhel5 too (I built for rhel 5 using the new spec).
> However, it is not clear for me whether I should use the setuptools
> for Fedora also, which just work the same way as before, or keep using the
> conditionals.
> What do you think?
> SPEC:
> http://roma.fedorapeople.org/specs/cgal-python.spec
> I will wait for your opinion before updating the .src.rpm



It'll be better to remove %bcond_with rhel and %{with rhel} macros and using 
%if ! (0%{?fedora} > 8 || 0%{?rhel} > 5) instead, the upcoming rhel6 will
automatically generate egg-info files.

You don't need BR:python-setuptools for fedora >8 || rhel >5.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]