Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579227 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dueno@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dueno@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Daiki Ueno <dueno@xxxxxxxxxx> 2010-04-19 04:26:05 EDT --- Hi Jan, I'm trying to review. 1. *.mo listed twice I got the following message when building: warning: File listed twice: /usr/share/locale/bg/LC_MESSAGES/byobu.mo The line "%{_datadir}/locale/*/LC_MESSAGES/%{name}.mo" in the %files section is unnecessary since "%files -f %{name}.lang" do the job. 2. messages are not translated According to po/de.po, "Help" should be translated into "Hilfe" under German locales. However, it does not effect. Try: LANG=de_DE.UTF-8 byobu-config This is because wrong localedir is hard-coded in byobu-config: byobu-config:31:PKG="byobu" byobu-config:32:SHARE='/usr/share/'+PKG ... byobu-config:52:gettext.bindtextdomain(PKG, SHARE+'/po') The solution would be simply replacing the path in the last line with "/usr/share/locale". 3. desktop file I'm not sure this is the issue - byobu.desktop is really useful for users? The file also defines the Categories as GNOME;GTK;Utility, but neither GNOME nor GTK is used in byobu. See "A. Registered Categories" of desktop files: http://standards.freedesktop.org/menu-spec/latest/apa.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review