Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583301 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-04-19 02:56:24 EDT --- Review: Good: - name ok - rpmlint ok $ rpmlint ./whereami-1.0-2.fc13.src.rpm x86_64/whereami-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - description ok - %prep ok - %install looks a bit crazy, but ok - %clean there - %files ok - macros everywhere - no libs - no .la - arch ok - builds in mock: INFO: Done(whereami-1.0-2.fc13.src.rpm) Config(default) 1 minutes 6 seconds - %build see needswork Needswork/shouldwork: - configure: WARNING: unrecognized options: --disable-static - please use INSTALL="install -p" to preserve timestamps ############################################################################## There are only SHOULDS left. ############################################################################## APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review