Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-libnotify - libnotify notification plugin for gaim https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211834 ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2006-10-23 17:45 EST ------- Couple of quick notes: 1. libtool isn't needed as a BR. 2. Excluding *.a & .la files is generally frowned upon. Instead use the 'disable-static' switch when you configure the package, so the static lib isn't built. Also, do something like "find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'", in the install section, to get rid of the lib archive. 3. Requires for libnotify is unnecessary. The devel package sonames will pull in these dependencies. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review