[Bug 576431] Package Review: skipfish - Web application security scanner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576431

--- Comment #12 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-18 02:56:21 EDT ---
(In reply to comment #11)
> Please could you specify what dir lines you find redundant?

Hi Michal,

you can omit all %dir lines in your spec file. These lines simply add empty
directories to the binary rpm and would only be necessary if no files were
supposed to be added to these directories. But since the %file section contains
lines that place files in there, rpm creates the required directories
automatically:

%{_datadir}/%{name}/assets/index.html creates %{_datadir}/%{name} and
%{_datadir}/%{name}/assets, and finally puts index.html in "assets". Thus,
there's no need for 
%dir %{_datadir}/%{name} and
%dir %{_datadir}/%{name}/assets.

Please also append a slash to "dictionaries" in order to make clear a folder
(including all containing files) is added: 
%{_datadir}/%{name}/dictionaries/
It's not required but this way it's easier to notice "dictionaries" is a folder
and not a file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]