Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583141 --- Comment #8 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-04-17 23:43:22 EDT --- (In reply to comment #5) > Review: > > Good: > - name ok > - group ok > - arch ok > - BR ok > - rpmlint ignorable: > $ rpmlint ./nautilus-pastebin-0.4.1-3.fc13.src.rpm > noarch/nautilus-pastebin-0.4.1-3.fc13.noarch.rpm > nautilus-pastebin.noarch: W: dangerous-command-in-%pre rm > nautilus-pastebin.noarch: W: dangerous-command-in-%post rm > 2 packages and 0 specfiles checked; 0 errors, 2 warnings. > - source match upstream: ad10c5ce66a81bb2b17be31c2e07d4c7 > - %install ok > - correctly installing of locales > - %doc ok > > > Needswork/couldwork: > - URL: when you put there %{version} in too, you don't need to change it all > the time. > - what does your sed in %prep do? > There is no line 'X-Ubuntu-Gettext-Domain=nautilus-pastebin' or am I wrong? the sed gets rid of the above line, since the line is useless to Fedora > - RPM_OPT_FLAGS are now obsolete, with the BuildArch: noarch > - license wrong: It's GPLv2+ and not GPLv2 Corrected. > - description: > last line has as a first character a space and misses a dot at the end > - could you please be a bit more explicit in %files? corrected. > with: > %{python_sitelib}/pastebin > %{python_sitelib}/nautilus_pastebin-*-py?.?.egg-info > you know when the egg fails to build > corrected > (In reply to comment #4) > > > I never used this macro before, but it needs to be: > > > %gconf_schema_prepare %{name} (etc..) > > > > > > > I think I've used the macro correctly. > > I don't know that macro so I ran: > $ rpm --eval %gconf_schema_prepare > > if [ "$1" -gt 1 ] ; then > rm -rf /var/lib/rpm-state/gconf/* > for schema in ; do > if test -f /etc/gconf/schemas/"$schema".schemas ; then > cp -p /etc/gconf/schemas/"$schema".schemas > /var/lib/rpm-state/gconf/ || : > fi > done > fi > > Means it will copy a schemas file around but does not do something with the > argument you provide (whyever). > > On http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf is as > example: > %gconf_schema_prepare foobar > > So I guess they want to have: > %gconf_schema_prepare nautilus-pastebin > > Or why do you think, your usage is right? > > gotten rid of the macro entirely. will incorporate it when its usage is clearer. > ############################################################################## > > Current BLOCKER: > - license > - unsure about the macro > > -> rest is SHOULD (In reply to comment #6) > Try to install it: > > # rpm -i noarch/nautilebin-0.4.1-3.fc13.noarch.rpm > I/O warning : failed to load external entity > "/etc/gconf/schemas//etc/gconf/schemas/nautilus-pastebin.schemas.schemas" > »/etc/gconf/schemas//etc/gconf/schemas/nautilus-pastebin.schemas.schemas« > konnte nicht geöffnet werden: Datei oder Verzeichnis nicht gefunden > > As you see, it really needs to be %gconf_schema_prepare nautilus-pastebin corrected by removal of macro. (In reply to comment #7) > Missing Requires, when starting > $ nautilus-pastebin.py > Traceback (most recent call last): > File "/usr/bin/nautilus-pastebin.py", line 33, in <module> > import nautilus > ImportError: No module named nautilus > > nautilus-python does not contain a python module (or is wrong installed) > > > Have you tried to run the programm? just did. i get the same error. I think I need to have a chat with upstream before proceeding with this package :( .Anyway, it isn't listing nautilus-python as a Requires. [Ankur1@localhost data]$ rpm -qp --requires /var/lib/mock/fedora-rawhide-i386/result/nautilus-pastebin-0.4.1-3.fc14.noarch.rpm /bin/sh /bin/sh /usr/bin/python GConf2 GConf2 GConf2 config(nautilus-pastebin) = 0.4.1-3.fc14 python(abi) = 2.6 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review