Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583141 --- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-04-17 10:00:13 EDT --- Hey, Thank you for the review :) (In reply to comment #1) > Hmm, do you want to build for python3 or not? > It looks like you started and that's it (haven't tried it either, yet). > removed the py3 support, will find out from upstream if this will work for py3 or not and later do it. > getting rid of rpmlint output: > $ rpmlint x86_64/nautilus-pastebin-* > nautilus-pastebin.x86_64: E: no-binary > nautilus-pastebin.x86_64: E: file-in-usr-marked-as-conffile > /usr/share/gconf/schemas/nautilus-pastebin.schemas > nautilus-pastebin.x86_64: W: dangerous-command-in-%pre rm > nautilus-pastebin.x86_64: W: dangerous-command-in-%post rm > nautilus-pastebin-debuginfo.x86_64: E: empty-debuginfo-package > 2 packages and 0 specfiles checked; 3 errors, 2 warnings. > > * file-in-usr-marked-as-conffile: > The schemas are in /etc/gconf/schemas/, if you put this schemas also there, > this will be gone The setup.py installs it in /usr/share/gconf, how do i move it to this correct location? That's what I'm not clear on. > * dangerous-command-in-* rm > %gconf_schema_prepare contains rm as a command. I don't know if this is sane, > but this seems like a false positive I've taken the macro from here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf > * empty-debuginfo-package: > This usually appears, when you build without the optflags. > > You should try: > CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build Done. dint change anything :X new srpms: http://ankursinha.fedorapeople.org/nautilus-pastie/ rpmlint output: [Package@localhost SPECS]$ rpmlint nautilus-pastebin.spec ../SRPMS/nautilus-pastebin-0.4.1-2.fc12.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm nautilus-pastebin.i686: E: no-binary nautilus-pastebin.i686: E: file-in-usr-marked-as-conffile /usr/share/gconf/schemas/nautilus-pastebin.schemas nautilus-pastebin.i686: W: percent-in-%pre nautilus-pastebin.i686: W: percent-in-%post nautilus-pastebin.i686: W: percent-in-%preun nautilus-pastebin-debuginfo.i686: E: empty-debuginfo-package 4 packages and 1 specfiles checked; 3 errors, 3 warnings. regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review