Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mkvtoolnix - Matroska container utilites https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177134 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias@xxxxxxxxxxxx ------- Additional Comments From matthias@xxxxxxxxxxxx 2006-10-23 06:57 EST ------- I really don't think this package can get Fedora Legal approval as-is, and removing any of its demuxing capabilities will reduce its usefulness. I've packaged it too, outside of Extras for now. Regarding the package currently under review : - The "buildroot != /" check in %install is not needed - Passing STRIP=/bin/true to make install will fix the empty debuginfo package - sed is in the build requirements exceptions (no need to list it) (*) - The gui sub-package should probably require the current version-release - Maybe the "base64tool" should be considered to have a too generic name and have it changed to something like "mkvbase64tool" or "mkvb64tool"? (*) I assume it's listed because the version is required for inline replacing -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review